open-maui/OpenMaui
2
0
Fork 0
Code Issues Releases 1

Fix BindingModes: SkiaLabel, SkiaScrollView

Browse Source 
- SkiaLabel.cs: Added TwoWay to VerticalTextAlignment, LineBreakMode,
  MaxLines, LineHeight, CharacterSpacing, Padding
- SkiaScrollView.cs: Added TwoWay to Orientation, HorizontalScrollBarVisibility,
  VerticalScrollBarVisibility, ScrollBarColor, ScrollBarWidth

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
David H. Friedel Jr.
2026-01-01 14:29:10 -05:00
parent 55d4a6eaad
commit 4d225a43ef
3 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
MERGE_TRACKING.md
View File

@@ -78,7 +78,7 @@
| SkiaImageButton.cs | [ ] | | | SkiaImageButton.cs | [ ] | |
| SkiaIndicatorView.cs | [ ] | | | SkiaIndicatorView.cs | [ ] | |
| SkiaItemsView.cs | [x] | Added GetItemView() method | | SkiaItemsView.cs | [x] | Added GetItemView() method |
| SkiaLabel.cs | [ ] | | | SkiaLabel.cs | [x] | **FIXED 2026-01-01** - All BindingModes TwoWay |
| SkiaLayoutView.cs | [ ] | Contains SkiaGrid, SkiaStackLayout, SkiaAbsoluteLayout, GridLength, GridPosition | | SkiaLayoutView.cs | [ ] | Contains SkiaGrid, SkiaStackLayout, SkiaAbsoluteLayout, GridLength, GridPosition |
| SkiaMenuBar.cs | [ ] | Contains MenuItem, MenuBarItem | | SkiaMenuBar.cs | [ ] | Contains MenuItem, MenuBarItem |
| SkiaNavigationPage.cs | [ ] | | | SkiaNavigationPage.cs | [ ] | |
@@ -87,7 +87,7 @@
| SkiaProgressBar.cs | [x] | Verified - Progress=OneWay, rest TwoWay, logic matches | | SkiaProgressBar.cs | [x] | Verified - Progress=OneWay, rest TwoWay, logic matches |
| SkiaRadioButton.cs | [ ] | | | SkiaRadioButton.cs | [ ] | |
| SkiaRefreshView.cs | [ ] | | | SkiaRefreshView.cs | [ ] | |
| SkiaScrollView.cs | [ ] | | | SkiaScrollView.cs | [x] | **FIXED 2026-01-01** - All BindingModes TwoWay |
| SkiaSearchBar.cs | [ ] | | | SkiaSearchBar.cs | [ ] | |
| SkiaShell.cs | [x] | **FIXED 2026-01-01** - Added FlyoutTextColor, ContentBackgroundColor, route registration, query parameters, OnScroll | | SkiaShell.cs | [x] | **FIXED 2026-01-01** - Added FlyoutTextColor, ContentBackgroundColor, route registration, query parameters, OnScroll |
| SkiaSlider.cs | [x] | FIXED - Value=OneWay, rest TwoWay (agent had inverted all) | | SkiaSlider.cs | [x] | FIXED - Value=OneWay, rest TwoWay (agent had inverted all) |

6
Views/SkiaLabel.cs
View File

@@ -145,6 +145,7 @@ public class SkiaLabel : SkiaView
typeof(TextAlignment), typeof(TextAlignment),
typeof(SkiaLabel), typeof(SkiaLabel),
TextAlignment.Center, TextAlignment.Center,
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaLabel)b).Invalidate()); propertyChanged: (b, o, n) => ((SkiaLabel)b).Invalidate());
/// <summary> /// <summary>
@@ -156,6 +157,7 @@ public class SkiaLabel : SkiaView
typeof(LineBreakMode), typeof(LineBreakMode),
typeof(SkiaLabel), typeof(SkiaLabel),
LineBreakMode.TailTruncation, LineBreakMode.TailTruncation,
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaLabel)b).Invalidate()); propertyChanged: (b, o, n) => ((SkiaLabel)b).Invalidate());
/// <summary> /// <summary>
@@ -167,6 +169,7 @@ public class SkiaLabel : SkiaView
typeof(int), typeof(int),
typeof(SkiaLabel), typeof(SkiaLabel),
0, 0,
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaLabel)b).OnTextChanged()); propertyChanged: (b, o, n) => ((SkiaLabel)b).OnTextChanged());
/// <summary> /// <summary>
@@ -178,6 +181,7 @@ public class SkiaLabel : SkiaView
typeof(float), typeof(float),
typeof(SkiaLabel), typeof(SkiaLabel),
1.2f, 1.2f,
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaLabel)b).OnTextChanged()); propertyChanged: (b, o, n) => ((SkiaLabel)b).OnTextChanged());
/// <summary> /// <summary>
@@ -189,6 +193,7 @@ public class SkiaLabel : SkiaView
typeof(float), typeof(float),
typeof(SkiaLabel), typeof(SkiaLabel),
0f, 0f,
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaLabel)b).Invalidate()); propertyChanged: (b, o, n) => ((SkiaLabel)b).Invalidate());
/// <summary> /// <summary>
@@ -200,6 +205,7 @@ public class SkiaLabel : SkiaView
typeof(SKRect), typeof(SKRect),
typeof(SkiaLabel), typeof(SkiaLabel),
SKRect.Empty, SKRect.Empty,
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaLabel)b).OnTextChanged()); propertyChanged: (b, o, n) => ((SkiaLabel)b).OnTextChanged());
#endregion #endregion

5
Views/SkiaScrollView.cs
View File

@@ -21,6 +21,7 @@ public class SkiaScrollView : SkiaView
typeof(ScrollOrientation), typeof(ScrollOrientation),
typeof(SkiaScrollView), typeof(SkiaScrollView),
ScrollOrientation.Both, ScrollOrientation.Both,
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaScrollView)b).InvalidateMeasure()); propertyChanged: (b, o, n) => ((SkiaScrollView)b).InvalidateMeasure());
/// <summary> /// <summary>
@@ -32,6 +33,7 @@ public class SkiaScrollView : SkiaView
typeof(ScrollBarVisibility), typeof(ScrollBarVisibility),
typeof(SkiaScrollView), typeof(SkiaScrollView),
ScrollBarVisibility.Auto, ScrollBarVisibility.Auto,
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaScrollView)b).Invalidate()); propertyChanged: (b, o, n) => ((SkiaScrollView)b).Invalidate());
/// <summary> /// <summary>
@@ -43,6 +45,7 @@ public class SkiaScrollView : SkiaView
typeof(ScrollBarVisibility), typeof(ScrollBarVisibility),
typeof(SkiaScrollView), typeof(SkiaScrollView),
ScrollBarVisibility.Auto, ScrollBarVisibility.Auto,
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaScrollView)b).Invalidate()); propertyChanged: (b, o, n) => ((SkiaScrollView)b).Invalidate());
/// <summary> /// <summary>
@@ -54,6 +57,7 @@ public class SkiaScrollView : SkiaView
typeof(SKColor), typeof(SKColor),
typeof(SkiaScrollView), typeof(SkiaScrollView),
new SKColor(0x80, 0x80, 0x80, 0x80), new SKColor(0x80, 0x80, 0x80, 0x80),
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaScrollView)b).Invalidate()); propertyChanged: (b, o, n) => ((SkiaScrollView)b).Invalidate());
/// <summary> /// <summary>
@@ -65,6 +69,7 @@ public class SkiaScrollView : SkiaView
typeof(float), typeof(float),
typeof(SkiaScrollView), typeof(SkiaScrollView),
8f, 8f,
BindingMode.TwoWay,
propertyChanged: (b, o, n) => ((SkiaScrollView)b).Invalidate()); propertyChanged: (b, o, n) => ((SkiaScrollView)b).Invalidate());
#endregion #endregion