open-maui/OpenMaui
2
0
Fork 0
Code Issues Releases 1

refactor: replace Console.WriteLine with DiagnosticLog service
All checks were successful
CI / Build (Linux) (push) Successful in 21s
Details

Browse Source 
Replace 495+ Console.WriteLine debug statements across handlers, dispatching, services, views, and window components with centralized DiagnosticLog service for proper logging infrastructure. Add new DiagnosticLog.cs service with Debug/Error methods to eliminate debug logging pollution in production code.
This commit is contained in:
David H. Friedel Jr.
2026-03-06 22:06:08 -05:00
parent 08e0c4d2b9
commit e55230c441
70 changed files with 814 additions and 638 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Native/GLibNative.cs
View File

@@ -1,6 +1,7 @@
using System;
using System.Collections.Generic;
using System.Runtime.InteropServices;
using Microsoft.Maui.Platform.Linux.Services;
namespace Microsoft.Maui.Platform.Linux.Native;
@@ -38,7 +39,7 @@ public static class GLibNative
}
catch (Exception ex)
{
Console.WriteLine("[GLibNative] Error in idle callback: " + ex.Message);
DiagnosticLog.Error("GLibNative", "Error in idle callback", ex);
}
if (!flag)
{
@@ -68,7 +69,7 @@ public static class GLibNative
}
catch (Exception ex)
{
Console.WriteLine("[GLibNative] Error in timeout callback: " + ex.Message);
DiagnosticLog.Error("GLibNative", "Error in timeout callback", ex);
}
if (!flag)
{

11
Native/WebKitNative.cs
View File

@@ -1,6 +1,7 @@
using System;
using System.Collections.Generic;
using System.Runtime.InteropServices;
using Microsoft.Maui.Platform.Linux.Services;
namespace Microsoft.Maui.Platform.Linux.Native;
@@ -131,14 +132,14 @@ internal static class WebKitNative
_handle = dlopen(text, 258);
if (_handle != IntPtr.Zero)
{
Console.WriteLine("[WebKitNative] Loaded " + text);
DiagnosticLog.Debug("WebKitNative", "Loaded " + text);
break;
}
}
if (_handle == IntPtr.Zero)
{
Console.WriteLine("[WebKitNative] Failed to load WebKitGTK library");
DiagnosticLog.Warn("WebKitNative", "Failed to load WebKitGTK library");
return false;
}
@@ -170,7 +171,7 @@ internal static class WebKitNative
if (intPtr != IntPtr.Zero)
{
_gSignalConnectData = Marshal.GetDelegateForFunctionPointer<GSignalConnectDataDelegate>(intPtr);
Console.WriteLine("[WebKitNative] Loaded g_signal_connect_data");
DiagnosticLog.Debug("WebKitNative", "Loaded g_signal_connect_data");
}
}
@@ -297,7 +298,7 @@ internal static class WebKitNative
{
if (_gSignalConnectData == null || webView == IntPtr.Zero)
{
Console.WriteLine("[WebKitNative] Cannot connect load-changed: signal connect not available");
DiagnosticLog.Warn("WebKitNative", "Cannot connect load-changed: signal connect not available");
return 0uL;
}
_loadChangedCallbacks[webView] = callback;
@@ -317,7 +318,7 @@ internal static class WebKitNative
{
if (_gSignalConnectData == null || webView == IntPtr.Zero)
{
Console.WriteLine("[WebKitNative] Cannot connect script-dialog: signal connect not available");
DiagnosticLog.Warn("WebKitNative", "Cannot connect script-dialog: signal connect not available");
return 0uL;
}
_scriptDialogCallbacks[webView] = callback;